Moved typing indicator to Composer#31648
Open
niamu wants to merge 1 commit intoelement-hq:developfrom
Open
Conversation
github-actions
bot
added
the
Z-Community-PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19855 and #16304
This is mostly a proposal as I know there have been previous design discussions apparently that didn't reach a conclusion.
This moves the typing indicator to above the composer input without changing any of the functionality. The design eliminates the need for any extra spacing to be maintained in the timeline which simplifies a lot of other aspects of the code.
Attached is a short demo where I toggle the typing indicator on and off manually to show how it leaves the timeline unaffected and the new style for it.
new_typing_indicator.mov